allow passing env vars to server from command line #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwin-ant
force-pushed
the
ashwin/envvar
branch
3 times, most recently
from
936345b to
8a7da27
Compare
9 tasks
jspahrsummers
requested changes
Jan 10, 2025
Member
jspahrsummers
left a comment
jspahrsummers
left a comment
There was a problem hiding this comment.
Overall looks good! IMO supporting -- should be a blocker, but the other comments are not essential
Comment on lines
20
to
39
| for (let i = 0; i < args.length; i++) { | ||
| if (args[i] === "-e" && i + 1 < args.length) { | ||
| const [key, value] = args[++i].split("="); | ||
| if (key && value) { | ||
| envVars[key] = value; | ||
| } | ||
| } else if (!command) { | ||
| command = args[i]; | ||
| } else { | ||
| mcpServerArgs.push(args[i]); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
There must be an npm package that can make this easier, but nbd
bin/cli.js
Outdated
| let command = null; | ||
|
|
||
| for (let i = 0; i < args.length; i++) { | ||
| if (args[i] === "-e" && i + 1 < args.length) { |
Member
There was a problem hiding this comment.
We should support -- to end arg parsing, in cases where you might have a server that accepts its own -e option
client/src/components/Sidebar.tsx
Outdated
| }: SidebarProps) => { | ||
| const [theme, setTheme] = useTheme(); | ||
| const [showEnvVars, setShowEnvVars] = useState(false); | ||
| const [shownEnvVars, setShownEnvVars] = useState<Record<string, boolean>>({}); |
Member
There was a problem hiding this comment.
I'd probably just use a Set, but up to you
jerome3o-anthropic
previously approved these changes
Jan 10, 2025
Member
jerome3o-anthropic
left a comment
jerome3o-anthropic
left a comment
There was a problem hiding this comment.
one question - and I also agree that -- would be great to have here, but im happy to take that on as a follow up if you don't have time
client/src/components/Sidebar.tsx
Outdated
| newEnv[""] = ""; | ||
| newEnv[key] = ""; | ||
| setEnv(newEnv); | ||
| setShownEnvVars({}); |
Member
There was a problem hiding this comment.
will this hide all previously shown env vars? intential?
ashwin-ant
force-pushed
the
ashwin/envvar
branch
from
00f9228 to
052de86
Compare
IgnacioC44
referenced
this pull request
in MCPJam/inspector
Jun 21, 2025
allow passing env vars to server from command line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./bin/cli.js -e FOO=BAR /path/to/serverand have it pass the env var to the MCP server.Motivation and Context
Addresses #94.
How Has This Been Tested?
Verified with command above.
Breaking Changes
No
Types of changes
Checklist
Additional context